[ https://issues.apache.org/jira/browse/HDDS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505027#comment-16505027 ]
Xiaoyu Yao commented on HDDS-130: --------------------------------- [~Sandeep Nemuri], thanks for working on this. The patch looks good to me. I have the following comments: Can we fix this via the Junit @BeforeTest @AfterTest so that the fix can apply to both generateConfigurationsSuccess, generateConfigurationsFailure and some new tests added in future? > TestGenerateOzoneRequiredConfigurations should use > GenericTestUtils#getTempPath to set output directory > ------------------------------------------------------------------------------------------------------- > > Key: HDDS-130 > URL: https://issues.apache.org/jira/browse/HDDS-130 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: Tools > Reporter: Nanda kumar > Assignee: Sandeep Nemuri > Priority: Minor > Labels: newbie > Attachments: HDDS-130.001.patch > > > {{TestGenerateOzoneRequiredConfigurations}} uses current directory (.) as its > output location which generates {{ozone-site.xml}} file in the directory from > where the test-cases is executed. Insead we should use > {{GenericTestUtils#getTempPath}} to get the output directory for test-cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org