[
https://issues.apache.org/jira/browse/HDFS-13566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507512#comment-16507512
]
Ajay Kumar commented on HDFS-13566:
-----------------------------------
[~vagarychen], thanks for working on this.
few minor nits and suggestions:
* Server
** L3156-61 wrap call to each listener in try catch to avoid skipping stop
call on remaining listeners due to error/exception in one listener.
* {{NameNode#getNameNodeAddressHostAdditionalPortString}} When more than one
additional ports are configured current iterator approach will mostly return
address string for port inserted first. In this case i suggest either returning
a random additional port or parametrizing it with port, so that caller can get
it for specific port.
* Rename#getNameNodeAddressHostAdditionalPortString to something like
getNNAdditionalRpcAddress ? (getNameNodeAddressHostAdditionalPortString sounds
bit verbose)
* {{Namenode#getAdditionalNameNodeAddresses}} In addition to this function
shall we have a additional function (getNNRpcAddresses) to return all rpc
addresses NN is currently listening, (currently this function sends additional
rpc). This will give callers flexibility to choose either one of them.
* MiniDFSCluster getNameNodeAdditionalPort/getNameNodeAdditionalPort doesn't
seems to return random port if more than one 1 additional rpc address are
configured.
* TestDistributedFileSystem#testDFSClientNNAdditionalPort: Shall we add test
case for multiple additional rpc ports. (i.e In dfs cluster with more than 2+
rpc port, client should be able to make rpc call with all of them, if we return
random rpc port from NameNode#getNameNodeAddressHostAdditionalPortString than
each rpc port should have equal probability of being returned, this will ensure
traffic is not skewed towards one port )
> Add configurable additional RPC listener to NameNode
> ----------------------------------------------------
>
> Key: HDFS-13566
> URL: https://issues.apache.org/jira/browse/HDFS-13566
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ipc
> Reporter: Chen Liang
> Assignee: Chen Liang
> Priority: Major
> Attachments: HDFS-13566.001.patch, HDFS-13566.002.patch
>
>
> This Jira aims to add the capability to NameNode to run additional
> listener(s). Such that NameNode can be accessed from multiple ports.
> Fundamentally, this Jira tries to extend ipc.Server to allow configured with
> more listeners, binding to different ports, but sharing the same call queue
> and the handlers. Useful when different clients are only allowed to access
> certain different ports. Combined with HDFS-13547, this also allows different
> ports to have different SASL security levels.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
