[ https://issues.apache.org/jira/browse/HDDS-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510326#comment-16510326 ]
Xiaoyu Yao edited comment on HDDS-159 at 6/12/18 10:34 PM: ----------------------------------------------------------- Thanks [~ljain] for working on it. The patch looks good to me overall. I just have few comments: *RestClient.java* Line 370-373: the response should be fully consumed before volume list parsing like below: {code:java} HttpEntity response = executeHttpRequest(httpGet); EntityUtils.consume(response); ListVolumes volumeList = ListVolumes._parse_(EntityUtils._toString_(response)); {code} Line 596-599, Line 771-773: same as above. *TestBucketRatis.java* Line 105: logic below needs to be removed to improve coverage. {code:java} if(clientProtocol.equals(RestClient.class)){ return; } {code} *TestBuckets.java* Line 292: same as above. *TestVolume.java* Line 231/318: same as above. was (Author: xyao): Thanks [~ljain] for working on it. The patch looks good to me overall. I just have few comments: *RestClient.java* Line 370-373: the response should be fully consumed before volume list parsing like below: {code} HttpEntity response=executeHttpRequest(httpGet); EntityUtils._consume_(response); ListVolumes volumeList= ListVolumes._parse_(EntityUtils._toString_(response)); {code} Line 596-599, Line 771-773: same as above. *TestBucketRatis.java* Line 105: logic below needs to be removed to improve coverage. {code} if(clientProtocol.equals(RestClient.class)){ return; } {code} *TestBuckets.java* Line 292: same as above. *TestVolume.java* Line 231/318: same as above. > RestClient: Implement list operations for volume, bucket and keys > ----------------------------------------------------------------- > > Key: HDDS-159 > URL: https://issues.apache.org/jira/browse/HDDS-159 > Project: Hadoop Distributed Data Store > Issue Type: Task > Components: Ozone Client > Reporter: Lokesh Jain > Assignee: Lokesh Jain > Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-159.001.patch > > > Currently RestClient does not provide implementation for list volume, list > buckets and list keys. This Jira aims to add the implementation and necessary > tests for the same. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org