[ 
https://issues.apache.org/jira/browse/HDFS-13609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16523243#comment-16523243
 ] 

Erik Krogen edited comment on HDFS-13609 at 6/26/18 5:54 AM:
-------------------------------------------------------------

Thanks [~shv] and [~linyiqun]!

[~csun]:
* You are right, according to [Oracle's 
conventions|http://www.oracle.com/technetwork/articles/java/index-137868.html]:
{quote}
Insert a blank comment line between the description and the list of tags, as 
shown.
{quote}
I was not aware of this, thanks for educating me.
* Thanks for the catch.

I have attached v004 patch to document the final changes. Given how minor the 
v003 -> v004 patch change is (Chao's two whitespace comments, I just committed 
this based on the +1s on v003.

Note that the bad Jenkins run above is just because I committed the patch but 
didn't yet mark the issue as resolved. Fixed now.


was (Author: xkrogen):
Thanks [~shv] and [~linyiqun]!

[~csun]:
* You are right, according to [Oracle's 
conventions|http://www.oracle.com/technetwork/articles/java/index-137868.html]:
{quote}
Insert a blank comment line between the description and the list of tags, as 
shown.
{quote}
I was not aware of this, thanks for educating me.
* Thanks for the catch.

I have attached v004 patch to document the final changes. Given how minor the 
v003 -> v004 patch change is (Chao's two whitespace comments, I just committed 
this based on the +1s on v003.

> [Edit Tail Fast Path Pt 3] NameNode-side changes to support tailing edits via 
> RPC
> ---------------------------------------------------------------------------------
>
>                 Key: HDFS-13609
>                 URL: https://issues.apache.org/jira/browse/HDFS-13609
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, namenode
>            Reporter: Erik Krogen
>            Assignee: Erik Krogen
>            Priority: Major
>             Fix For: HDFS-12943
>
>         Attachments: HDFS-13609-HDFS-12943.000.patch, 
> HDFS-13609-HDFS-12943.001.patch, HDFS-13609-HDFS-12943.002.patch, 
> HDFS-13609-HDFS-12943.003.patch, HDFS-13609-HDFS-12943.004.patch
>
>
> See HDFS-13150 for the full design.
> This JIRA is targetted at the NameNode-side changes to enable tailing 
> in-progress edits via the RPC mechanism added in HDFS-13608. Most changes are 
> in the QuorumJournalManager.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to