[ https://issues.apache.org/jira/browse/HDDS-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530473#comment-16530473 ]
Xiaoyu Yao commented on HDDS-187: --------------------------------- Thanks [~ajayydv] for the patch. It looks good to me overall. I just have a few comments: StateContext.java LINE 55: Should we define cmdStatusMap as a map of CommandStatus instead of CommandStatuser? Line 291: return null will need to make sure the callers from various subclasses do the null check to avoid NPE. Line 293: same as above, should we return CommandStatus instead of CommandStatuser to keep it immutable? Line 310: same as above Line 312: do we need an API to remove a command from the map? StorageContainerDatanodeProtocol.proto Line 141: should this be a int64 like the block deletion txID to avoid the string/uuid conversion overhead? Ozone-default.xml Can we rename ozone.command.status.report.interval to hdds.command.status.report.interval? HeartbeatEndpointTask.java Line 191/204/215: can this be consolidated into an updated version of StateContext#addCommand()? DeleteBlocksCommand/CloseContainerCommand.java Line 42: can we have a generic IdFactory to take care of these command ID creation? > Command status publisher for datanode > ------------------------------------- > > Key: HDDS-187 > URL: https://issues.apache.org/jira/browse/HDDS-187 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: SCM > Affects Versions: 0.2.1 > Reporter: Ajay Kumar > Assignee: Ajay Kumar > Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-187.00.patch, HDDS-187.01.patch, HDDS-187.02.patch, > HDDS-187.03.patch, HDDS-187.04.patch > > > Currently SCM sends set of commands for DataNode. DataNode executes them via > CommandHandler. This jira intends to create a Command status publisher which > will return status of these commands back to the SCM. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org