[
https://issues.apache.org/jira/browse/HDDS-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534179#comment-16534179
]
Nanda kumar commented on HDDS-228:
----------------------------------
Thanks [~ajayydv] for working on this. Overall the patch looks good to me.
Instead of adding container entry in {{contReplicaMap}} inside
{{addContainerReplica}} call, can we do it in {{addContainer}} call. This way
{{containerMap}} and {{contReplicaMap}} will be consistent. We can add a empty
set here, later on the set can be updated via {{addContainerReplica}}. We
should throw {{SCMException("No such container.", FAILED_TO_FIND_CONTAINER)}}
exception if we are not able to find the container in {{contReplicaMap}}, this
way we can detect inconsistency in ContainerStateMap, if any.
It would be nice to have DatanodeDetails as varargs in {{addContainerReplica}},
so that it will be easy to update/add multiple datanodes at the same time.
Inside {{ContainerStateManager#allocateContainer}} method we should update the
container replica after we add the container to ContainerStateMap (line: 314)
> Add the ReplicaMaps to ContainerStateManager
> --------------------------------------------
>
> Key: HDDS-228
> URL: https://issues.apache.org/jira/browse/HDDS-228
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: SCM
> Reporter: Anu Engineer
> Assignee: Ajay Kumar
> Priority: Major
> Attachments: HDDS-228.00.patch, HDDS-228.01.patch
>
>
> We need to maintain a list of data nodes in the SCM that tells us where a
> container is located. This created from the container reports. The HDDS-175
> refactored the class to make this separation easy and this JIRA is a followup
> that keeps a hash table to track this information.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
