[
https://issues.apache.org/jira/browse/HDFS-1073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070320#comment-13070320
]
Matt Foley commented on HDFS-1073:
----------------------------------
I like the new model, and I like the way upgrade is handled.
In NNStorageArchivalManager and JournalManager:
I have difficulty with naming a method or interface "archiver" and then
implementing it as "delete". That seems an incorrect abstraction. How about
changing the name of the i/f StorageArchiver to "StorageDisposition" with
methods "disposeLog" and "disposeImage"? Then it could have implementations
DeletionStorageDisposition and ArchiverStorageDisposition, without prejudice.
Similarly in JournalManager, the method archiveLogsOlderThan() could be renamed
disposeLogsOlderThan().
I'm not set on the specific word choice "disposition" or "dispose", but I think
that if an allowable implementation of an interface is deletion, then it
shouldn't be named "Archive".
> Simpler model for Namenode's fs Image and edit Logs
> ----------------------------------------------------
>
> Key: HDFS-1073
> URL: https://issues.apache.org/jira/browse/HDFS-1073
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 0.23.0
> Reporter: Sanjay Radia
> Assignee: Todd Lipcon
> Fix For: 0.23.0
>
> Attachments: hdfs-1073-editloading-algos.txt, hdfs-1073-merge.patch,
> hdfs-1073-merge.patch, hdfs-1073.txt, hdfs1073.pdf, hdfs1073.pdf,
> hdfs1073.pdf, hdfs1073.tex
>
>
> The naming and handling of NN's fsImage and edit logs can be significantly
> improved resulting simpler and more robust code.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
