[
https://issues.apache.org/jira/browse/HDDS-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541006#comment-16541006
]
Anu Engineer commented on HDDS-187:
-----------------------------------
[~ajayydv] Thanks for taking care of this issue. Some very minor comments on
the patch v9.
* CommandStatus.java:32*: rewrite as {{private Status status;}}
* Is it possible to add cmdID to base SCMCommand Class instead of adding it to
all derived classes ?
* Same comment on Handle Call, may be make an abstract class that deal with
the status and ID ?
* Do we need _HDDsIDFactory_ at all from quick reading of code it looks like
all we need is *Time.MonotonicNow()*
* Why Skip Reregister command in HeartbeatTask.java ? It will be
* Should we do the _addCommandStatus_() inside addCommand() ?
> Command status publisher for datanode
> -------------------------------------
>
> Key: HDDS-187
> URL: https://issues.apache.org/jira/browse/HDDS-187
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: SCM
> Affects Versions: 0.2.1
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-187.00.patch, HDDS-187.01.patch, HDDS-187.02.patch,
> HDDS-187.03.patch, HDDS-187.04.patch, HDDS-187.05.patch, HDDS-187.06.patch,
> HDDS-187.07.patch, HDDS-187.08.patch, HDDS-187.09.patch
>
>
> Currently SCM sends set of commands for DataNode. DataNode executes them via
> CommandHandler. This jira intends to create a Command status publisher which
> will return status of these commands back to the SCM.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
