[
https://issues.apache.org/jira/browse/HDDS-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543557#comment-16543557
]
Xiaoyu Yao commented on HDDS-250:
---------------------------------
Thanks [~hanishakoneru] for working on this. The patch v2 looks good to me.
Just few minor comments:
OzoneConsts.java
Line 74: comments need to be updated to reflect the
/volume/scmid/containerDirXXX/metadata (I see we have some related comments in
ContainerReader.java, may be add a reference here and remove the obsolete
comments)
Line 75: the comment can be removed to match the code change. Also suggest
document the metadata format on the DN side.
BlockDeletingService.java
Line 166: should we keep using the ContainerData base class here to make it
generic so that it can handle different containerdata subclasses? Based on
that, I like the original name for the ContainerData#getDataPath instead of
ContainerData#getChunksPath, which seems more tied to the KeyValueContainerData
implementation.
Line 170: can we add a check ensure the container is an instance of
KeyVlaueContainerData before cast? NIT: containerName ->container
> Cleanup ContainerData
> ---------------------
>
> Key: HDDS-250
> URL: https://issues.apache.org/jira/browse/HDDS-250
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-250.000.patch, HDDS-250.001.patch,
> HDDS-250.002.patch
>
>
> The following functions in ContainerData are redundant. MetadataPath and
> ChunksPath are specific to KeyValueContainerData.
> ContainerPath is the common path in ContainerData which points to the base
> dir of the container.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
