[ 
https://issues.apache.org/jira/browse/HDFS-13610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546979#comment-16546979
 ] 

Erik Krogen commented on HDFS-13610:
------------------------------------

I just committed this based on [~shv]'s +1. Confirmed that the unit tests 
reported as failing pass fine locally, with the exception of 
TestDFSInotifyEventStreamKerberized, which is also failing on trunk for me. 
Thanks [~linyiqun], [~vagarychen], [~csun], [~shv] for the reviews!

> [Edit Tail Fast Path Pt 4] Cleanup: integration test, documentation, remove 
> unnecessary dummy sync
> --------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-13610
>                 URL: https://issues.apache.org/jira/browse/HDFS-13610
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, journal-node, namenode
>            Reporter: Erik Krogen
>            Assignee: Erik Krogen
>            Priority: Major
>             Fix For: HDFS-12943
>
>         Attachments: HDFS-13610-HDFS-12943.000.patch, 
> HDFS-13610-HDFS-12943.001.patch, HDFS-13610-HDFS-12943.002.patch, 
> HDFS-13610-HDFS-12943.003.patch, HDFS-13610-HDFS-12943.004.patch
>
>
> See HDFS-13150 for full design.
> This JIRA is targeted at cleanup tasks:
> * Add in integration testing. We can expand {{TestStandbyInProgressTail}}
> * Documentation in HDFSHighAvailabilityWithQJM
> * Remove the dummy sync added as part of HDFS-10519; it is unnecessary since 
> now in-progress tailing does not rely on the JN committedTxnId
> A few bugs are also fixed:
> * Due to changes in HDFS-13609 to enable use of the RPC mechanism whenever 
> inProgressOK is true, there were codepaths which would use the RPC mechanism 
> even when dfs.ha.tail-edits.in-progress was false, meaning that the JNs did 
> not enable the cache. Update the QJM logic to only use selectRpcInputStreams 
> if this config is true.
> * Fix a false error logged when the layout version changes
> * Fix the logging when a layout version change occurs to avoid printing out a 
> placeholder value (Integer.MAX_VALUE)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to