[
https://issues.apache.org/jira/browse/HDFS-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13071129#comment-13071129
]
Hadoop QA commented on HDFS-2149:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12487829/HDFS-2149.diff
against trunk revision 1150960.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/1018//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/1018//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1018//console
This message is automatically generated.
> Move EditLogOp serialisation and deserialation into one place
> -------------------------------------------------------------
>
> Key: HDFS-2149
> URL: https://issues.apache.org/jira/browse/HDFS-2149
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 0.23.0
>
> Attachments: HDFS-2149.diff, HDFS-2149.diff, HDFS-2149.diff,
> HDFS-2149.diff
>
>
> On trunk serialisation of editlog ops is in FSEditLog#log* and
> deserialisation is in FSEditLogOp.*Op . This improvement is to move the
> serialisation code into one place, i.e under FSEditLogOp.*Op.
> This is part of HDFS-1580.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
