[ https://issues.apache.org/jira/browse/HDDS-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549403#comment-16549403 ]
Mukul Kumar Singh commented on HDDS-239: ---------------------------------------- Thanks for the review [~xyao], patch v4 fixes the review comments. PipelineManager.java Line 112: NIT: an extra "pipeline" in comments bq. done Line 127: should we use the lease manager to handle the CLOSING->CLOSED state transition when CLOSE event is not received timely? This could be handled as TODO in a separate JIRA. bq. The pipeline will transition from closing to close when all the underlying containers have been closed on the pipeline. This is being done as part of a followup jira. PipelineSelector.java Line 72-73: should we move the pipelineLeaseManager/stateMachine to PipelineManager class so that the RatisManagerImpl and StandaloneMangerImpl may have different state machines? This way, the logic for state transition around line 261-266 can be consolidated into PipelineManager#initializePipeline(). bq. Interesting point. However keeping the statemachine in pipeline selector will ensure that the external behavior of the pipelines remains the same with respect to standAlone/Ratis pipelines. Also, the createPipeline/closePipeline are not hooked up with state changes because we currently rely only getReplicationPipeline() for create pipeline. bq. This is handled as part of the followup jira Line 399: I think we need to handle the create timeout by releasing the nodes when the DN get closed. Is it possible to include it in this patch? We can leave the close pipeline, continer, etc. later. bq. The next patch is ready right now. I just wanted to intoduce a pipeline state manager with this patch and ensure that the current pipeline code keeps on working. I will post the followup patch soon. ScmConfigKeys.java: Line 244: please update the unit test TestOzoneConfigurationFields that verifies this new configuration keys. bq. updated the ozone-default.xml. > Add Pipeline StateManager to track and transition pipeline states > ----------------------------------------------------------------- > > Key: HDDS-239 > URL: https://issues.apache.org/jira/browse/HDDS-239 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: SCM > Affects Versions: 0.2.1 > Reporter: Mukul Kumar Singh > Assignee: Mukul Kumar Singh > Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-239.001.patch, HDDS-239.002.patch, > HDDS-239.003.patch > > > With addition of pipeline recovery in Ozone, pipeline failures need to be > handled both in Ozone client as well as SCM. This jira adds a pipeline state > Manager to manage pipeline state transitions. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org