[ https://issues.apache.org/jira/browse/HDDS-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551226#comment-16551226 ]
Ajay Kumar commented on HDDS-262: --------------------------------- [~bharatviswa] thanks for working on this. Patch looks good. Few nits. # HddsVolume: I feel dummyVolume really means failedVolume in this case. Shall we rename it accordingly? # TestVolumeSet: L212 NIT readOnlyvolumePath to readOnlyVolumePath # Shall we test mock NodeReport getting these failed volumes and handling it appropriately? > Send SCM healthy and failed volumes in the heartbeat > ---------------------------------------------------- > > Key: HDDS-262 > URL: https://issues.apache.org/jira/browse/HDDS-262 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Reporter: Bharat Viswanadham > Assignee: Bharat Viswanadham > Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-262.00.patch > > > The current code only sends volumes which are successfully created during > datanode startup. For any volume an error occurred during HddsVolume object > creation, we should move that volume to failedVolume Map. This should be sent > to SCM as part of NodeReports. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org