[ 
https://issues.apache.org/jira/browse/HDDS-288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nanda kumar updated HDDS-288:
-----------------------------
    Issue Type: Bug  (was: Improvement)

> Fix bugs in OpenContainerBlockMap
> ---------------------------------
>
>                 Key: HDDS-288
>                 URL: https://issues.apache.org/jira/browse/HDDS-288
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-288.20180724.patch
>
>
> - OpenContainerBlockMap should not be synchronized for a better performance. 
> - addChunkToMap may add the same chunk twice.  See the comments below.
> {code}
>       keyDataSet.putIfAbsent(blockID.getLocalID(), getKeyData(info, 
> blockID)); // (1) when id is absent, it puts
>       keyDataSet.computeIfPresent(blockID.getLocalID(), (key, value) -> { // 
> (2) now, the id is present, it adds again.
>         value.addChunk(info);
>         return value;
>       });
> {code}
> - In removeContainer(..), use remove(..) instead of computeIfPresent(..).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to