[
https://issues.apache.org/jira/browse/HDDS-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16558064#comment-16558064
]
Elek, Marton commented on HDDS-201:
-----------------------------------
Thank you very much [~Sandeep Nemuri] to work on this. The patch looks good to
me. +1
One minor thing: I would use the name ContainerCreation and PipelineCreation
instead of Container and Pipeline at ContainerMapping on PipelineSelector. I
think it's more clean what is the process which is followed by the lease
manager.
Other than this one I am + 1 for this patch.
I did a full build and check the thread dump and worked well:
{code}
"Container-LeaseManager#LeaseMonitor" #15 daemon prio=5 os_prio=0
tid=0x00007f97b4cf7800 nid=0x99 waiting on condition [0x00007f97941a8000]
java.lang.Thread.State: TIMED_WAITING (sleeping)
at java.lang.Thread.sleep(Native Method)
at
org.apache.hadoop.ozone.lease.LeaseManager$LeaseMonitor.run(LeaseManager.java:234)
at java.lang.Thread.run(Thread.java:748)
{code}
> Add name for LeaseManager
> -------------------------
>
> Key: HDDS-201
> URL: https://issues.apache.org/jira/browse/HDDS-201
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: SCM
> Reporter: Elek, Marton
> Assignee: Sandeep Nemuri
> Priority: Minor
> Labels: newbie
> Fix For: 0.2.1
>
> Attachments: HDDS-201.001.patch
>
>
> During the review of HDDS-195 we realised that one server could have multiple
> LeaseManagers (for example one for the watchers one for the container
> creation).
> To make it easier to monitor it would be good to use some specific names for
> the release manager.
> This jira is about adding a new field (name) to the release manager which
> should be defined by a constructor parameter and should be required.
> It should be used in the name of the Threads and all the log message
> (Something like "Starting CommandWatcher LeasManager....")
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
