[
https://issues.apache.org/jira/browse/HDDS-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559781#comment-16559781
]
Mukul Kumar Singh commented on HDDS-273:
----------------------------------------
Thanks for working on this [~ljain].
1) DatanodeDeletedBlockTransactions:75, the null check should go before the for
loop. this will avoid unnecessary looping.
2) StorageContainerDatanodeProtocol.proto: lets also add the container id in
the response. this will skip the need of having transactionToContainerIdMap
3) DatanodeBlockLogImpl.java:382. Lets move the putIfAbsent before the
addTransaction call. putIfAbsent returns the previous value which is the input
to the addTransaction.
> DeleteLog entries should be purged only after corresponding dns commit the
> transaction
> --------------------------------------------------------------------------------------
>
> Key: HDDS-273
> URL: https://issues.apache.org/jira/browse/HDDS-273
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: SCM
> Reporter: Lokesh Jain
> Assignee: Lokesh Jain
> Priority: Critical
> Fix For: 0.2.1
>
> Attachments: HDDS-273.001.patch, HDDS-273.002.patch,
> HDDS-273.003.patch
>
>
> Currently DeleteBlockLogImpl removes an entry corresponding to a deleteBlock
> as soon as it receives an acknowledgement from a single DN. The entries
> should be deleted only after all corresponding dns give an acknowledgement
> for the delete command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
