[
https://issues.apache.org/jira/browse/HDDS-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561649#comment-16561649
]
Lokesh Jain commented on HDDS-298:
----------------------------------
Thanks [~ajayydv] for working on this! The patch looks very good to me. Please
find my comments below.
# TestContainerMapping: 19,187 - unused import and commented code
# I do not think for closed containers case we should be adding a pipeline in
the PipelineManager data structures. This causes problem when the dns holding
the container change. Also the pipeline should just be a dummy wrapper over dns
in case of closed containers since dns holding a closed container are very
dynamic in nature. Therefore I feel changes in PipelineManager and
PipelineSelector may not be needed?
# ContainerMapping#getContainerWithPipeline:201-205 - There should just be two
conditions for getting a pipeline. If container is open we should use
pipelineManager else we should just wrap the dns from the replicaMap into a
pipeline. I have a similar argument as point 2 for the case of closed
containers. If the container is closed but its pipeline is not yet finalized
then their dns may not match.
> Implement SCMClientProtocolServer.getContainerWithPipeline for closed
> containers
> --------------------------------------------------------------------------------
>
> Key: HDDS-298
> URL: https://issues.apache.org/jira/browse/HDDS-298
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: SCM
> Reporter: Elek, Marton
> Assignee: Ajay Kumar
> Priority: Critical
> Fix For: 0.2.1
>
> Attachments: HDDS-298.00.patch
>
>
> As [~ljain] mentioned during the review of HDDS-245
> SCMClientProtocolServer.getContainerWithPipeline doesn't return with good
> data for closed containers. For closed containers we are maintaining the
> datanodes for a containerId in the ContainerStateMap.contReplicaMap. We need
> to create fake Pipeline object on-request and return it for the client to
> locate the right datanodes to download data.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
