[ https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562502#comment-16562502 ]
Tsz Wo Nicholas Sze edited comment on HDDS-226 at 7/30/18 11:29 PM: -------------------------------------------------------------------- Thanks for the update. Just some minor comments: - addEntryToLocationInfoList(..) and getKeylength() are only used once. Let's remove them. - The changes in OmKeyLocationInfoGroup are not used. Please revert them. +1 patch looks good otherwise. was (Author: szetszwo): Thanks for the update. Just some minor comments: - addEntryToLocationInfoList(..) and getKeylength() are only used once. Let's remove them. - The changes in OmKeyLocationInfoGroup are not used. Please revert them. > Client should update block length in OM while committing the key > ---------------------------------------------------------------- > > Key: HDDS-226 > URL: https://issues.apache.org/jira/browse/HDDS-226 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: Ozone Manager > Reporter: Mukul Kumar Singh > Assignee: Shashikant Banerjee > Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-226.00.patch, HDDS-226.01.patch, HDDS-226.02.patch, > HDDS-226.03.patch, HDDS-226.04.patch, HDDS-226.05.patch, HDDS-226.06.patch, > HDDS-226.07.patch > > > Currently the client allocate a key of size with SCM block size, however a > client can always write smaller amount of data and close the key. The block > length in this case should be updated on OM. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org