[
https://issues.apache.org/jira/browse/HDFS-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566196#comment-16566196
]
Konstantin Shvachko commented on HDFS-13767:
--------------------------------------------
Looks good. Comments are good, but look through all of them and check the
spelling or phrasing.
# I suggest this comment change:
{code}
// The call processing should be postponed until the client's
// state id is aligned (>=) with the server state id. For ACTIVE,
// clients always have state id smaller than than the server's,
// so this check only applies to STANDBY and OBSERVER.
// NOTE:
// Inserting the call back to the queue can change the order of call
// execution compared to their original placement into the queue.
// This is not a problem, because HDFS does not have any constraints
// on ordering the incoming rpc requests.
// Also, Observer handles only reads, which are commutative.
// Re-queue the call and continue
internalQueueCall(call);
{code}
# You can use {{getLastSeenStateId()}} in
{{GlobalStateIdContext.updateResponseState()}} to avoid code redundancy.
# Also would be good to remove unused import in
{{ClientNamenodeProtocolTranslatorPB}} which was introduced by HDFS-13688.
> Add msync server implementation.
> --------------------------------
>
> Key: HDFS-13767
> URL: https://issues.apache.org/jira/browse/HDFS-13767
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Reporter: Chen Liang
> Assignee: Chen Liang
> Priority: Major
> Attachments: HDFS-13767-HDFS-12943.001.patch,
> HDFS-13767.WIP.001.patch, HDFS-13767.WIP.002.patch, HDFS-13767.WIP.003.patch,
> HDFS-13767.WIP.004.patch
>
>
> This is a followup on HDFS-13688, where msync API is introduced to
> {{ClientProtocol}} but the server side implementation is missing. This is
> Jira is to implement the server side logic.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
