[ https://issues.apache.org/jira/browse/HDFS-13746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581343#comment-16581343 ]
Daniel Templeton edited comment on HDFS-13746 at 8/15/18 4:54 PM: ------------------------------------------------------------------ Thanks, [~smeng], the patch looks great. One question: {code}Math.toIntExact(groupRefreshTimeoutSec) * 1000 * 30{code} Should that be {code}Math.toIntExact(groupRefreshTimeoutSec * 1000) * 30{code} or maybe even {code}Math.toIntExact(groupRefreshTimeoutSec * 1000 * 30){code} ? If you're going to proactively check for int overflows, it seems like you'd want to do it for the final product rather than a factor. Thoughts? was (Author: templedf): Thanks, [~smeng], the patch looks great. One question: {code}Math.toIntExact(groupRefreshTimeoutSec) * 1000 * 30{code} Should that be {code}Math.toIntExact(groupRefreshTimeoutSec * 1000) * 30{code} or maybe even {code}Math.toIntExact(groupRefreshTimeoutSec * 1000 * 30{code} ? If you're going to proactively check for int overflows, it seems like you'd want to do it for the final product rather than a factor. Thoughts? > Still occasional "Should be different group" failure in > TestRefreshUserMappings#testGroupMappingRefresh > ------------------------------------------------------------------------------------------------------- > > Key: HDFS-13746 > URL: https://issues.apache.org/jira/browse/HDFS-13746 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 3.0.0 > Reporter: Siyao Meng > Assignee: Siyao Meng > Priority: Major > Attachments: HDFS-13746.001.patch, HDFS-13746.002.patch, > HDFS-13746.003.patch, HDFS-13746.004.patch, HDFS-13746.005.patch > > > In https://issues.apache.org/jira/browse/HDFS-13723, increasing the amount of > time in sleep() helps but the problem still appears, which is annoying. > > Solution: > Use a loop to allow the test case to fail maxTrials times before declaring > failure. Wait 50 ms between each retry. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org