[
https://issues.apache.org/jira/browse/HDFS-13815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584635#comment-16584635
]
Yiqun Lin commented on HDFS-13815:
----------------------------------
Almost looks good to me. Some minors comments:
* Can you add {{else}} condition check for {{addMount}} as well? The same
problem will be happened in -add command.
* For the added UT:
# Add a new test case without option -order inputed.
# Add test cases for -add option like we did for -update option.
# "String src = "/test-updateOrderMountTable-"+order.toString()", missing a
space around '+'.
> RBF: Add check to order command
> -------------------------------
>
> Key: HDFS-13815
> URL: https://issues.apache.org/jira/browse/HDFS-13815
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: federation
> Affects Versions: 3.0.0
> Reporter: Soumyapn
> Assignee: Ranith Sardar
> Priority: Minor
> Attachments: HDFS-13815-001.patch
>
>
> No check being done on order command.
> It says successfully updated mount table if we don't specify order command
> and it is not updated in mount table
> Execute the dfsrouter update command with the below scenarios.
> 1. ./hdfs dfsrouteradmin -update /apps3 hacluster,ns2 /tmp6 RANDOM
> 2. ./hdfs dfsrouteradmin -update /apps3 hacluster,ns2 /tmp6 -or RANDOM
> 3. ./hdfs dfsrouteradmin -update /apps3 hacluster,ns2 /tmp6 -ord RANDOM
> 4. ./hdfs dfsrouteradmin -update /apps3 hacluster,ns2 /tmp6 -orde RANDOM
>
> The console message says, Successfully updated mount point. But it is not
> updated in the mount table.
>
> Expected Result:
> Exception on console as the order command is missing/not written properl
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
