[
https://issues.apache.org/jira/browse/HDDS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588633#comment-16588633
]
Elek, Marton commented on HDDS-364:
-----------------------------------
Thank you very much [~ajayydv] to work on this. Overall it looks good to me and
it was definitely missing until now.
1. What do you think about Node2ContainerMap? Do we need to update it as well?
2. As I see all the containers will be persisted twice. (First, they will be
imported, after that they will be reconciled.). Don't think it's a big problem.
IMHO later we need to cleanup all the processing path anyway.
One option may be just saving all the initial data to the state map without
processing the reports (checking the required closing state, etc.). The
downside here is some action would be delayed until the first real container
report.
3. The import part (in case of isRegisterCall=true) is the first part of
processContainerReport method. I think it would be very easy to move to a
separated method and call it independently from
SCMDatanodeProtocolServer.register method. Could be more simple, and maybe it
could be easier to test. Currently (as I understood) there is no specific test
to test the isRegisterCall=true path. But this is not a blocking problem.
Depends from your consideration...
> Update open container replica information in SCM during DN register
> -------------------------------------------------------------------
>
> Key: HDDS-364
> URL: https://issues.apache.org/jira/browse/HDDS-364
> Project: Hadoop Distributed Data Store
> Issue Type: New Feature
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-364.00.patch, HDDS-364.01.patch
>
>
> Update open container replica information in SCM during DN register.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
