[ 
https://issues.apache.org/jira/browse/HDFS-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079583#comment-13079583
 ] 

Todd Lipcon commented on HDFS-2225:
-----------------------------------

Looks pretty good. Only question: why not have StoragePurger continue to use 
EditLogFile and FSImageFile? ie why break out the arguments to File and 
transaction IDs? It seems like passing the classes allows us more room to add 
extra data about the stuff to be purged without having to change the interface.

> HDFS-2018 Part 1 : Refactor file management so its not in classes which 
> should be generic
> -----------------------------------------------------------------------------------------
>
>                 Key: HDFS-2225
>                 URL: https://issues.apache.org/jira/browse/HDFS-2225
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>         Attachments: HDFS-2225.diff, HDFS-2225.diff
>
>
> This is the first part of HDFS-2018 changes, to refactor some of the file 
> management classes so they're in file specific places rather than in the 
> generic classes. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to