[ https://issues.apache.org/jira/browse/HDDS-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591824#comment-16591824 ]
genericqa commented on HDDS-280: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 28s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m 17s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 22m 39s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 15m 22s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 11m 57s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 27s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 18m 22s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} shellcheck {color} | {color:red} 0m 1s{color} | {color:red} The patch generated 10 new + 3 unchanged - 1 fixed = 13 total (was 4) {color} | | {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m 12s{color} | {color:green} There were no new shelldocs issues. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 11m 46s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 23m 37s{color} | {color:green} root in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 49s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}108m 46s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:ba1ab08 | | JIRA Issue | HDDS-280 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12937006/HDDS-280.001.patch | | Optional Tests | asflicense shellcheck shelldocs mvnsite unit | | uname | Linux cc2c9975eb40 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 138b0c1 | | maven | version: Apache Maven 3.3.9 | | shellcheck | v0.4.6 | | shellcheck | https://builds.apache.org/job/PreCommit-HDDS-Build/836/artifact/out/diff-patch-shellcheck.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDDS-Build/836/testReport/ | | Max. process+thread count | 302 (vs. ulimit of 10000) | | modules | C: hadoop-ozone/acceptance-test . hadoop-ozone/docs U: . | | Console output | https://builds.apache.org/job/PreCommit-HDDS-Build/836/console | | Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Support ozone dist-start-stitching on openbsd/osx > ------------------------------------------------- > > Key: HDDS-280 > URL: https://issues.apache.org/jira/browse/HDDS-280 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Reporter: Elek, Marton > Assignee: Elek, Marton > Priority: Major > Attachments: HDDS-280.001.patch > > > {quote}Ozone is creating a symlink during the dist process. > Using the "ozone" directory as a destination name all the docker-based > acceptance tests and docker-compose files are more simple as they don't need > to have the version information in the path. > But to keep the version specific folder name in the tar file we create a > symbolic link during the tar creation. With the symbolic link and the > '–dereference' tar argument we can create the tar file which includes a > versioned directory (ozone-0.2.1) but we can use the a dist directory without > the version in the name (hadoop-dist/target/ozone). > {quote} > This is the description of the current > dev-support/bin/ozone-dist-tar-stitching. [~aw] in a comment for HDDS-276 > pointed to the problem that some bsd variants don't support the dereference > command line options of the ln command. > The main reason to use this approach is to get a simplified destination name > without the version (hadoop-dist/target/ozone instead of > hadoop-dist/target/ozone-0.2.1). It simplifies the docker-compose based > environments and acceptance tests, therefore I prefer to keep the simplified > destination name. > The issue is the tar file creation, if and only if we need the version number > in the name of the root directory inside of the tar. > Possible solutions: > # Use cp target/ozone target/ozone-0.2.1 + tar. It's simple but more slow > and requires more space. > # Do the tar distribution from docker all the time in case of 'dereference' > is not supported. Not very convenient > # Accept that tar will contain ozone directory and not ozone-0.2.1. This is > the more simple and can be improved with an additional VERSION file in the > root of the distribution. > # (+1) Use hadoop-dist/target/ozone-0.2.1 instead of > hadoop-dist/target/ozone. This is more complex for the docker based testing > as we need the explicit names in the compose files (volume: > ../../../hadoop-dist/target/ozone-0.2.1). The structure is more complex with > using version in the directory name. > Please comment your preference. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org