[ https://issues.apache.org/jira/browse/HDFS-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597916#comment-16597916 ]
Erik Krogen commented on HDFS-13749: ------------------------------------ I think the idea is sound. I hate to be unable to re-use the connections we already create to the NameNodes, but it seems there isn't another way around this since everything in the class is {{ClientProtocol}}... I also find it a little weird to be explicitly creating the PB translator; shouldn't we be using {{NameNodeProxies#createNonHAProxy()}}? We also need to make sure we don't create a new one every time we do a state fetch; they should be cached (maybe in a subclass of {{NNProxyInfo}}) > Use getServiceStatus to discover observer namenodes > --------------------------------------------------- > > Key: HDFS-13749 > URL: https://issues.apache.org/jira/browse/HDFS-13749 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Chao Sun > Assignee: Chao Sun > Priority: Major > Attachments: HDFS-13749-HDFS-12943.000.patch > > > In HDFS-12976 currently we discover NameNode state by calling > {{reportBadBlocks}} as a temporary solution. Here, we'll properly implement > this by using {{HAServiceProtocol#getServiceStatus}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org