[
https://issues.apache.org/jira/browse/HDDS-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604784#comment-16604784
]
Tsz Wo Nicholas Sze commented on HDDS-297:
------------------------------------------
The patch looks good. Some comments:
- Since ClosePipelineInfo has a messge, addPipelineActionIfAbsent(..) may not
work well -- There could be two CLOSE actions with differenet messages got
added.
-* BTW, what are the possible /PipelineActionPipelineAction(s)? Currently, we
only has one.
- Node2PipelineMap.getPipelines should not call computeIfPresent(..). It will
compute a new mapping. The code should be something like below.
{code}
final Set<PipelineID> s = dn2PipelineMap.get(datanode);
return s != null? Collections.unmodifiableSet(s): Collections.emptySet();
{code}
> Add pipeline actions in Ozone
> -----------------------------
>
> Key: HDDS-297
> URL: https://issues.apache.org/jira/browse/HDDS-297
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: SCM
> Reporter: Mukul Kumar Singh
> Assignee: Mukul Kumar Singh
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-297.001.patch, HDDS-297.002.patch,
> HDDS-297.003.patch, HDDS-297.004.patch, HDDS-297.005.patch,
> HDDS-297.006.patch, HDDS-297.007.patch, HDDS-297.008.patch,
> HDDS-297.009.patch, HDDS-297.010.patch
>
>
> Pipeline in Ozone are created out of a group of nodes depending upon the
> replication factor and type. These pipeline provide a transport protocol for
> data transfer.
> Inorder to detect any failure of pipeline, SCM should receive pipeline
> reports from Datanodes and process it to identify various raft rings.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
