[ https://issues.apache.org/jira/browse/HDFS-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083799#comment-13083799 ]
Todd Lipcon commented on HDFS-2018: ----------------------------------- (btw, some of the changes I made actually go back to things you had in your original patch. For example, the {{recoverUnclosedStreams}} API instead of doing lazy recovery-on-read. As you said over in HDFS-1580: {quote} Finalizing in getNumTransactions is a bit messy, because its difficult to tell if a inprogress file is actually inprogress or the result of a crashed namenode. I tried it in HDFS-2018, but ended up creating an explicit recoverUnclosedStreams() call {quote} > 1073: Move all journal stream management code into one place > ------------------------------------------------------------ > > Key: HDFS-2018 > URL: https://issues.apache.org/jira/browse/HDFS-2018 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Ivan Kelly > Assignee: Ivan Kelly > Fix For: 0.23.0 > > Attachments: HDFS-2018.diff, HDFS-2018.diff, HDFS-2018.diff, > HDFS-2018.diff, HDFS-2018.diff, HDFS-2018.diff, HDFS-2018.diff, > HDFS-2018.diff, HDFS-2018.diff, HDFS-2018.diff, HDFS-2018.diff, > HDFS-2018.diff, HDFS-2018.diff, HDFS-2018.diff, HDFS-2018.diff, > HDFS-2018.diff, hdfs-2018-otherapi.txt > > > Currently in the HDFS-1073 branch, the code for creating output streams is in > FileJournalManager and the code for input streams is in the inspectors. This > change does a number of things. > - Input and Output streams are now created by the JournalManager. > - FSImageStorageInspectors now deals with URIs when referring to edit logs > - Recovery of inprogress logs is performed by counting the number of > transactions instead of looking at the length of the file. > The patch for this applies on top of the HDFS-1073 branch + HDFS-2003 patch. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira