[ https://issues.apache.org/jira/browse/HDFS-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16620265#comment-16620265 ]
Xun REN commented on HDFS-13916: -------------------------------- Hi [~jojochuang], Yes, I am agree. I have thought about that also :) . So I will add a non-abstract method in the class FileSystem which will throw UnsupportedOperationException. If the concrete file system has implemented the method getSnapshotDiffReport(), it will call this method. If not, it will call the method in the FileSystem class which will throw UnsupportedOperationException. How do you think ? Or, you want me to create an abstract method in FileSystem and implement it on all the existing XXXFileSystem ? Thanks. > Distcp SnapshotDiff not completely implemented for supporting WebHdfs > --------------------------------------------------------------------- > > Key: HDFS-13916 > URL: https://issues.apache.org/jira/browse/HDFS-13916 > Project: Hadoop HDFS > Issue Type: Improvement > Components: distcp, webhdfs > Affects Versions: 3.0.1, 3.1.1 > Reporter: Xun REN > Assignee: Xun REN > Priority: Major > Labels: easyfix, newbie, patch > Attachments: HDFS-13916.002.patch, HDFS-13916.patch > > > [~ljain] has worked on the JIRA: > https://issues.apache.org/jira/browse/HDFS-13052 to provide the possibility > to make DistCP of SnapshotDiff with WebHDFSFileSystem. However, in the patch, > there is no modification for the real java class which is used by launching > the command "hadoop distcp ..." > > You can check in the latest version here: > [https://github.com/apache/hadoop/blob/branch-3.1.1/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpSync.java#L96-L100] > In the method "preSyncCheck" of the class "DistCpSync", we still check if the > file system is DFS. > So I propose to change the class DistCpSync in order to take into > consideration what was committed by Lokesh Jain. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org