[
https://issues.apache.org/jira/browse/HDDS-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16621929#comment-16621929
]
Elek, Marton commented on HDDS-455:
-----------------------------------
Thanks [~dineshchitlangia] the patch.
Overall It looks good to me. I like to see the progress to migrate everything
to picocli.
As a personal taste I would prefer to use 'ozone genconf /tmp' instead of
'ozone genconf target /tmp/'
I don't know any plan to add additional subcommands to genconf, so it could
cleaner/shorter to use it without the 'target'. (You can just override the call
method of the GenericCli in GenerateOzoneRequiredConfigurations.
Minor: the @Parent genconf is not used in OzoneSiteFileGenerator, but with
removing the subcommand it also will be fixed.
> genconf tool must use picocli
> -----------------------------
>
> Key: HDDS-455
> URL: https://issues.apache.org/jira/browse/HDDS-455
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Affects Versions: 0.2.1
> Reporter: Dinesh Chitlangia
> Assignee: Dinesh Chitlangia
> Priority: Minor
> Attachments: HDDS-455.001.patch
>
>
> Like ozone shell, genconf tool should use picocli to be consistent with other
> cli usage in the ozone world.
> Also replace the command 'output' with 'target' to make it more self
> explanatory.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
