[ 
https://issues.apache.org/jira/browse/HDFS-13947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636165#comment-16636165
 ] 

BELUGA BEHR commented on HDFS-13947:
------------------------------------

{code}
org.apache.hadoop.hdfs.client.impl.TestBlockReaderLocal.testStatisticsForErasureCodingRead
Ran a couple of times locally and it eventually passed.

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hdfs.client.impl.TestBlockReaderLocal
[WARNING] Tests run: 38, Failures: 0, Errors: 0, Skipped: 37, Time elapsed: 
12.324 s - in org.apache.hadoop.hdfs.client.impl.TestBlockReaderLocal
[INFO] 
[INFO] Results:
[INFO] 
[WARNING] Tests run: 38, Failures: 0, Errors: 0, Skipped: 37
{code}

{code}
hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency

Failed locally, even without patch applied.
{code}

Please accept this patch (and remove the white space).  Thanks!

> Review of DirectoryScanner Class
> --------------------------------
>
>                 Key: HDFS-13947
>                 URL: https://issues.apache.org/jira/browse/HDFS-13947
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>    Affects Versions: 3.2.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Major
>         Attachments: HDFS-13947.1.patch, HDFS-13947.2.patch, 
> HDFS-13947.3.patch, HDFS-13947.4.patch
>
>
> Review of Directory Scanner.   Replaced a lot of code with Guava MultiMap.  
> Some general house cleaning and improved logging.  For performance, using 
> {{ArrayList}} instead of {{LinkedList}} where possible, especially since 
> these lists can be quite large a LinkedList will consume a lot of memory and 
> be slow to sort/iterate over.
> https://stackoverflow.com/questions/322715/when-to-use-linkedlist-over-arraylist-in-java



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to