[ https://issues.apache.org/jira/browse/HDFS-13958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638362#comment-16638362 ]
BELUGA BEHR commented on HDFS-13958: ------------------------------------ {code} org.apache.hadoop.hdfs.TestLeaseRecovery2.testCloseWhileRecoverLease Failed, locally, with the same assertion failure, even without the patch {code} {code} org.apache.hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency.testGenerationStampInFuture org.apache.hadoop.hdfs.client.impl.TestBlockReaderLocal.testStatisticsForErasureCodingRead Known bad tests: https://issues.apache.org/jira/browse/HDFS-13947?focusedCommentId=16636187&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16636187 {code} {code} org.apache.hadoop.fs.TestHdfsNativeCodeLoader.testNativeCodeLoaded I don't think this one is my fault: java.lang.AssertionError: TestNativeCodeLoader: libhadoop.so testing was required, but libhadoop.so was not loaded. LD_LIBRARY_PATH = ${env.LD_LIBRARY_PATH}:/testptch/hadoop/hadoop-hdfs-project/hadoop-hdfs/target/native/target/usr/local/lib:/testptch/hadoop/hadoop-hdfs-project/hadoop-hdfs/../../hadoop-common-project/hadoop-common/target/native/target/usr/local/lib {code} Please consider this patch for inclusion into the project. [~elgoiri] Would you mind taking a look at this related patch? This patch has a lot of seemingly empty changes, but I removed a lot of dead white space for check-style. Thanks! > Miscellaneous Improvements for FsVolumeSpi > ------------------------------------------ > > Key: HDFS-13958 > URL: https://issues.apache.org/jira/browse/HDFS-13958 > Project: Hadoop HDFS > Issue Type: Improvement > Components: datanode > Affects Versions: 3.3.0 > Reporter: BELUGA BEHR > Assignee: BELUGA BEHR > Priority: Major > Attachments: HDFS-13958.1.patch > > > The work in [HDFS-13947] allowed for using {{ArrayList}} instead of > {{LinkedList}} when scanning DataNode local directories, however the > {{FsVolumeSpi}} implementations were still using (and forcing) > {{LinkedList}}. I propose changing the {{FsVolumeSpi}} signatures to allow > for {{Collection}} instead of {{LinkedList}}. Since I'm looking at the code, > I made some small improvements and check-style fixes. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org