[ 
https://issues.apache.org/jira/browse/HDFS-13961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638960#comment-16638960
 ] 

Konstantin Shvachko edited comment on HDFS-13961 at 10/4/18 11:45 PM:
----------------------------------------------------------------------

* I split {{TestObserverNode}} into 3 modules:
*# Main functionality {{TestObserverNode}}
*# Multiple Observers {{TestMultiObserverNode}}
*# Consistency of reads from Observers {{TestConsistentReadsObserver}}
* Made sure that the mini-cluster is spawn off only once per each module
* Moved common methods into {{HATestUtil}}  and {{MiniDFSCluster}}
* Corrected implementation in several places
* Also enabled testMsyncSimple(), which was ignored, waiting for HDFS-13880

[~vagarychen], [~csun] please take a look if you can.



was (Author: shv):
* I split {{TestObserverNode}} into 3 modules:
*# Main functionality {{TestObserverNode}}
*# Multiple Observers {{TestMultiObserverNode}}
*# Consistency of reads from Observers {{TestConsistentReadsObserver}}
* Made sure that the mini-cluster is spawn off only once per each module
* Moved common methods into {{HATestUtil}}  and {{MiniDFSCluster}}
* Corrected implementation in several places

[~vagarychen], [~csun] please take a look if you can.


> TestObserverNode refactoring
> ----------------------------
>
>                 Key: HDFS-13961
>                 URL: https://issues.apache.org/jira/browse/HDFS-13961
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: test
>    Affects Versions: HDFS-12943
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>            Priority: Major
>         Attachments: HDFS-13961-HDFS-12943.001.patch
>
>
> TestObserverNode combines unit tests for ObserverNode. The tests are of 
> different types. I propose to split them into separate modules, factor out 
> common methods, and optimize it so that it starts and shuts down 
> MIniHDFSCluster once for the entire test rather than for individual test 
> cases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to