[
https://issues.apache.org/jira/browse/HDDS-550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642515#comment-16642515
]
Xiaoyu Yao commented on HDDS-550:
---------------------------------
Thanks [~shashikant] for working on this. The patch looks pretty good to me.
+1 for catch up with the latest Ratis release which includes the third-party
shading change.
I just have one question for the other changes below:
ContainerStateMachine.java:
Line 247: not clear to me why we need to remove it and then put it back. The
original code only put without remove. Can you clarify?
{code}
247: writeChunkFuture.thenApply(r -> writeChunkFutureMap.remove(entryIndex));
248: writeChunkFutureMap.put(entryIndex, writeChunkFuture);
{code}
> Serialize ApplyTransaction calls per Container in ContainerStateMachine
> -----------------------------------------------------------------------
>
> Key: HDDS-550
> URL: https://issues.apache.org/jira/browse/HDDS-550
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Major
> Attachments: HDDS-550.001.patch, HDDS-550.002.patch
>
>
> As part of handling Node failures in Ozone, the block commit need to happen
> in order inside ContainerStateMachine per container. With RATIS-341, it is
> guaranteed that the applyTransaction calls for committing the write chunks
> will be initiated only when the WriteStateMachine data for write Chunk
> operations finish.
> This Jira is aimed at making all the applyTransaction operations inside
> ContainerStateMachine serial per container with a single thread Executor per
> container handling all applyTransactions calls.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
