[ https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659662#comment-16659662 ]
Wei-Chiu Chuang commented on HDFS-14015: ---------------------------------------- +1 for the 002 patch. Thanks [~templedf] Also note there's a similar usage in the Windows counterpart of this method in hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/os/windows/thread_local_storage.c But I don't have a Windows environment I can't verify. > Improve error handling in hdfsThreadDestructor in native thread local storage > ----------------------------------------------------------------------------- > > Key: HDFS-14015 > URL: https://issues.apache.org/jira/browse/HDFS-14015 > Project: Hadoop HDFS > Issue Type: Improvement > Components: native > Affects Versions: 3.0.0 > Reporter: Daniel Templeton > Assignee: Daniel Templeton > Priority: Major > Attachments: HDFS-14015.001.patch, HDFS-14015.002.patch > > > In the hdfsThreadDestructor() function, we ignore the return value from the > DetachCurrentThread() call. We are seeing cases where a native thread dies > while holding a JVM monitor, and it doesn't release the monitor. We're > hoping that logging this error instead of ignoring it will shed some light on > the issue. In any case, it's good programming practice. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org