[ https://issues.apache.org/jira/browse/HDDS-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661631#comment-16661631 ]
Yiqun Lin commented on HDDS-719: -------------------------------- Hi [~arpitagarwal], almost looks great to me, some review comments from me: I see the class {{HddsWhiteboxTestUtils}} is copied from the {{org.apache.hadoop.test.Whitebox}}, but that class was tagged as @Deprecated. Should we still use this one? Can we use {{org.mockito.internal.util.reflection.Whitebox}} in {{TestOmMetrics}} instead? At least, I don't think there is a necessity to have this. {{ITestOzoneContractGetFileStatus}} is also the intended change in this patch? I'm okay for this. Just making a confirm. > Remove Ozone dependencies on Apache Hadoop 3.2.0 > ------------------------------------------------ > > Key: HDDS-719 > URL: https://issues.apache.org/jira/browse/HDDS-719 > Project: Hadoop Distributed Data Store > Issue Type: Improvement > Components: SCM, test > Reporter: Arpit Agarwal > Assignee: Arpit Agarwal > Priority: Major > Attachments: HDDS-719.01.patch, HDDS-719.02.patch > > > A few more changes to remove dependencies on Hadoop 3.2.0. > # {{Time#getUtcTime}} used by SCM, unit tests and genesis. > # Whitebox class used by TestOmMetrics -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org