[ https://issues.apache.org/jira/browse/HDFS-13996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669282#comment-16669282 ]
Wei-Chiu Chuang commented on HDFS-13996: ---------------------------------------- Thanks [~smeng] The patch mostly makes sense to me. One suggestion to improve maintainability: could you remove the operation ACLS_CUSTOM_USER_GROUP_NAMES? It is not a HTTPFS operation after all. And you can have operation FILEACLS to run testCustomizedUserAndGroupNames() after testFileAcls(). That is, run two tests for the case of FILEACLS > Make HttpFS' ACLs RegEx configurable > ------------------------------------ > > Key: HDFS-13996 > URL: https://issues.apache.org/jira/browse/HDFS-13996 > Project: Hadoop HDFS > Issue Type: Improvement > Components: httpfs > Affects Versions: 2.6.5, 3.0.3, 2.7.7 > Reporter: Siyao Meng > Assignee: Siyao Meng > Priority: Major > Attachments: HDFS-13996.001.patch, HDFS-13996.002.patch > > > Previously in HDFS-11421, WebHDFS' ACLs RegEx is made configurable, but it's > not configurable yet in HttpFS. For now in HttpFS, the ACL permission pattern > is fixed to DFS_WEBHDFS_ACL_PERMISSION_PATTERN_DEFAULT. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org