[
https://issues.apache.org/jira/browse/HDDS-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670495#comment-16670495
]
Ajay Kumar commented on HDDS-120:
---------------------------------
[~dineshchitlangia] thanks for working on this. Patch LGTM. Few comments:
* BlockData
** L273 toString: I am not aware of what all metadata contains in this case,
so wanted to ask if really want to print all of it? IMO blockId, size and
blockCommitSequenceId might be enough for audit purpose.
** Similerly chunksize is pretty small do we need it in default audit logs?
May be we can define two levels of logging, at default level we just print high
level info while in second case we can print more detailed info.
** getChunksForAudit: Shall we make it private as its not used anywhere else?
* DNAction: Since string names are same as enum variables shall we simplify it
by removing constructor and corresponding variable.
something like
{code:java}
CREATE_CONTAINER;
@Override
public String getAction() {
return this.toString();
}{code}
* HddsDispatcher
** L143-144: Does not having createContainer command there constitutes an
error there? [~anu], [~xyao] can shed some light?
** L336: NIT may be switch will be more readable? (dont feel strongly about it
though)
** L142/150/164/172/196 Nit Space after "//"
* Can we create some unit tests for changes in {{HddsDispatcher}} and
{{TestBlockData}} using {{GenericTestUtils.LogCapturer}}?
> Adding HDDS datanode Audit Log
> ------------------------------
>
> Key: HDDS-120
> URL: https://issues.apache.org/jira/browse/HDDS-120
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Xiaoyu Yao
> Assignee: Dinesh Chitlangia
> Priority: Major
> Labels: alpha2
> Attachments: HDDS-120.001.patch
>
>
> This can be useful to find users who overload the DNs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
