[
https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16673722#comment-16673722
]
Yongjun Zhang commented on HDFS-14015:
--------------------------------------
Thanks [~templedf], good work!
It seems good to me, but couple of things:
1. In addition to getName(), I hope to get the thread id. See code from class
Thread:
{code}
public String toString() {
ThreadGroup group = getThreadGroup();
if (group != null) {
return "Thread[" + getName() + "," + getPriority() + "," +
group.getName() + "]";
} else {
return "Thread[" + getName() + "," + getPriority() + "," +
"" + "]";
}
}
{code}
and
{code}
public long getId() {
return tid;
}
{code}
2. Suggest to define 256 as a constant.
3. I wish we can test the output. But I know it's not easy to reproduce, thus
not easy to test. I wonder if it can be tested with an OOM error within java
world.
Thanks.
> Improve error handling in hdfsThreadDestructor in native thread local storage
> -----------------------------------------------------------------------------
>
> Key: HDFS-14015
> URL: https://issues.apache.org/jira/browse/HDFS-14015
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: native
> Affects Versions: 3.0.0
> Reporter: Daniel Templeton
> Assignee: Daniel Templeton
> Priority: Major
> Attachments: HDFS-14015.001.patch, HDFS-14015.002.patch,
> HDFS-14015.003.patch, HDFS-14015.004.patch, HDFS-14015.005.patch,
> HDFS-14015.006.patch, HDFS-14015.007.patch
>
>
> In the hdfsThreadDestructor() function, we ignore the return value from the
> DetachCurrentThread() call. We are seeing cases where a native thread dies
> while holding a JVM monitor, and it doesn't release the monitor. We're
> hoping that logging this error instead of ignoring it will shed some light on
> the issue. In any case, it's good programming practice.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
