[ https://issues.apache.org/jira/browse/HDFS-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092749#comment-13092749 ]
Laxman commented on HDFS-1217: ------------------------------ +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. Hi Nicholas, Thanks a lot for taking a look. When i ran the tests with this patch, TestHost2NodesMap and TestOfflineEditsViewer tests are failing. Looks they are not related. > Some methods in the NameNdoe should not be public > ------------------------------------------------- > > Key: HDFS-1217 > URL: https://issues.apache.org/jira/browse/HDFS-1217 > Project: Hadoop HDFS > Issue Type: Improvement > Components: name-node > Reporter: Tsz Wo (Nicholas), SZE > Assignee: Laxman > Attachments: HDFS-1217.patch > > > There are quite a few NameNode methods which are not required to be public. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira