[
https://issues.apache.org/jira/browse/HDFS-13998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678733#comment-16678733
]
Xiao Chen commented on HDFS-13998:
----------------------------------
Thanks [~zvenczel] for the patch, and [~ayushtkn] for the discussion.
As discussed in HDFS-13732, IMO it's worth the RPC call to make the tool more
accurate, which reduces support / admin confusion.
Patch looks good in general. +1 pending a few nits:
- The text {{"files to " + actualECPolicyName + " policy"}} would end up having
2 'policy' at the end of the sentence, because the variable is already added
with the text
- Prefer not to change the original text of "setting erasure coding policy on a
non-empty directory ...", I doubt that will cause any confusion, and in docs we
say {{REPLICATION is a special policy}}, which indicates it can be considered
an EC policy. This also means no existing tests need to be changed
- Trivial but we seem to be having too many empty lines between line 364 and
line 380. Can we perhaps remove #368 and #374 to make the code better clustered?
> ECAdmin NPE with -setPolicy -replicate
> --------------------------------------
>
> Key: HDFS-13998
> URL: https://issues.apache.org/jira/browse/HDFS-13998
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: erasure-coding
> Affects Versions: 3.2.0, 3.1.2
> Reporter: Xiao Chen
> Assignee: Zsolt Venczel
> Priority: Major
> Attachments: HDFS-13998.01.patch
>
>
> HDFS-13732 tried to improve the output of the console tool. But we missed the
> fact that for replication, {{getErasureCodingPolicy}} would return null.
> This jira is to fix it in ECAdmin, and add a unit test.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
