[ 
https://issues.apache.org/jira/browse/HDFS-14050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681844#comment-16681844
 ] 

Hrishikesh Gadre commented on HDFS-14050:
-----------------------------------------

ah...i didn't know that [~knanasi] ! I verified that indeed is the case.

[https://github.com/qos-ch/slf4j/blob/a81440ea36676f3b090f5a4ccba70d17c7b80f6e/slf4j-api/src/main/java/org/slf4j/helpers/MessageFormatter.java#L167-L174]

Let me update the patch accordingly.

 

> Use parameterized logging construct in NamenodeFsck class
> ---------------------------------------------------------
>
>                 Key: HDFS-14050
>                 URL: https://issues.apache.org/jira/browse/HDFS-14050
>             Project: Hadoop HDFS
>          Issue Type: Task
>    Affects Versions: 3.0.0
>            Reporter: Hrishikesh Gadre
>            Assignee: Hrishikesh Gadre
>            Priority: Trivial
>         Attachments: HDFS-14050-001.patch, HDFS-14050-002.patch, 
> HDFS-14050-003.patch
>
>
> HDFS-13695 implemented a change to use slf4j logger (instead of commons 
> logging). But the NamenodeFsck class is still not using parameterized logging 
> construct. This came up during the code review for HADOOP-11391. We should 
> change logging statements in NamenodeFsck to use slf4j style parameterized 
> logging apis.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to