[ https://issues.apache.org/jira/browse/HDDS-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681964#comment-16681964 ]
Jitendra Nath Pandey commented on HDDS-709: ------------------------------------------- Some other comments. # In {{checkIfContainerNotOpenException}}, why do we need to dig through exceptions? Is it possible to communicate back via protocol? # Unused port added to {{CloseContainerCommandHandler}}. # {{if (containerState == State.OPEN || containerState == State.CLOSING)}} Ideally we should not need this check to mark container UNHEALTHY. For a CLOSED container, it should not even come to this code path. # In {{validateContainerCommand}}, it might be better to use switch statement on cmdType for better readability. > Modify Close Container handling sequence on datanodes > ----------------------------------------------------- > > Key: HDDS-709 > URL: https://issues.apache.org/jira/browse/HDDS-709 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: Ozone Datanode > Reporter: Shashikant Banerjee > Assignee: Shashikant Banerjee > Priority: Major > Attachments: HDDS-709.000.patch, HDDS-709.001.patch, > HDDS-709.002.patch, HDDS-709.003.patch, HDDS-709.004.patch > > > With quasi closed container state for handling majority node failures, the > close container handling sequence in Datanodes need to change. Once the > datanodes receive a close container command from SCM, the open container > replicas individually be marked in the closing state. In a closing state, > only the transactions coming from the Ratis leader are allowed , all other > write transaction will fail. A close container transaction will be queued via > Ratis on the leader which will be replayed to the followers which makes it > transition to CLOSED/QUASI CLOSED state. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org