[
https://issues.apache.org/jira/browse/HDDS-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682227#comment-16682227
]
Jitendra Nath Pandey edited comment on HDDS-709 at 11/10/18 6:14 AM:
---------------------------------------------------------------------
{quote}This check is there mark the container unhealthy in case there is an
applyTransaction...
{quote}
There could be a possibility that {{applyTransaction}} is called on a closed
container, and fails with ContainerClosed exception, in that case we should not
mark it as unhealthy. But I think, that scenario should be handled by catching
appropriate exception. This code path will be executed only for non-closed or
non-quasi-closed containers, and therefore we should not need to check
container state. Instead, we should add a {{Preconditions}} check to ensure the
state is the expected state.
was (Author: jnp):
{quote}This check is there mark the container unhealthy in case there is an
applyTransaction...
{quote}
There could be a possibility that {{applyTransaction}} is called on a closed
container, and fails with ContainerClosed exception, in that case we should not
mark it as unhealthy. But I think, that scenario should be handled by catching
appropriate exception. This code path will be executed only for non-closed or
non-quasi-closed containers, and therefore we should not need to check
container state.
> Modify Close Container handling sequence on datanodes
> -----------------------------------------------------
>
> Key: HDDS-709
> URL: https://issues.apache.org/jira/browse/HDDS-709
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Datanode
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Major
> Attachments: HDDS-709.000.patch, HDDS-709.001.patch,
> HDDS-709.002.patch, HDDS-709.003.patch, HDDS-709.004.patch, HDDS-709.005.patch
>
>
> With quasi closed container state for handling majority node failures, the
> close container handling sequence in Datanodes need to change. Once the
> datanodes receive a close container command from SCM, the open container
> replicas individually be marked in the closing state. In a closing state,
> only the transactions coming from the Ratis leader are allowed , all other
> write transaction will fail. A close container transaction will be queued via
> Ratis on the leader which will be replayed to the followers which makes it
> transition to CLOSED/QUASI CLOSED state.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
