[ 
https://issues.apache.org/jira/browse/HDDS-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686055#comment-16686055
 ] 

Ajay Kumar commented on HDDS-836:
---------------------------------

[~xyao] thanks for review. patch v1 to address comments and jenkins issues.
{quote}OzoneBlockTokenIdentifier.java

Line 67: I think we should build the user based on the blockid instead of using 
null or empty string here.
{quote}
 done.
{quote}OzoneSecretKey.java

Line 58: should we put this into security config or some dev only 
configuration? 
{quote}
 assigned it from constructor. Client using it can pass this value from config.
{quote}Line 113-154: can we separate these key encode/decoe stuff into utility 
class or use the ca client interface?
{quote}
Moved it to SecurityUtil.( this class doesn't look like a CertificateClient.)

> Create Ozone identifier for delegation token and block token
> ------------------------------------------------------------
>
>                 Key: HDDS-836
>                 URL: https://issues.apache.org/jira/browse/HDDS-836
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>          Components: Security
>            Reporter: Ajay Kumar
>            Assignee: Ajay Kumar
>            Priority: Major
>             Fix For: 0.4.0
>
>         Attachments: HDDS-836-HDDS-4.00.patch, HDDS-836-HDDS-4.01.patch
>
>
> Create Ozone identifier for delegation token and block token.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to