[ https://issues.apache.org/jira/browse/HDDS-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687011#comment-16687011 ]
Xiaoyu Yao commented on HDDS-120: --------------------------------- Thanks [~dineshchitlangia] for the update. Patch v5 looks pretty good to me. Two more comments: HddsDispatcher.java Line 86: dnActionTypeMap can be eliminated by leveraging HddsUtils.isReadOnly(msg) with a helper function like below {code} private EventType getActionType(ContainerCommandRequestProto msg) { return HddsUtils.isReadOnly(msg) ? EventType.READ : EventType.WRITE } {code} Line 460/476: let's put some null or fixed INVALID user/ip for now instead of using the routines from Hadoop RPC Server. We will provide a GRPC Security Context later so that they can retrieved properly. > Adding HDDS datanode Audit Log > ------------------------------ > > Key: HDDS-120 > URL: https://issues.apache.org/jira/browse/HDDS-120 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Reporter: Xiaoyu Yao > Assignee: Dinesh Chitlangia > Priority: Major > Labels: alpha2 > Attachments: HDDS-120.001.patch, HDDS-120.002.patch, > HDDS-120.003.patch, HDDS-120.004.patch, HDDS-120.005.patch > > > This can be useful to find users who overload the DNs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org