[ 
https://issues.apache.org/jira/browse/HDFS-13998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688719#comment-16688719
 ] 

Daniel Templeton commented on HDFS-13998:
-----------------------------------------

[~vinayrpet] and [~xiaochen], that's a hard-line interpretation of the 
compatibility guidelines.  The intent of the guideline is to avoid breaking 
scripts that rely on the output of our CLIs.  From the perspective of parsing 
CLI output, HDFS-13732 is not a breaking change.  From the perspective of 
behavior, it's a little grey.  Strictly speaking it's a behavioral change that 
could break a script that doesn't know if it's passing a {{-policy}} arg and is 
using the output to tell for some reason.  I find that scenario pretty 
unlikely, though.

The guidelines are guidelines.  Common sense still takes precedence.  In this 
case, EC is a new feature, and the probability that a script exists that would 
be broken by this change is vanishingly small.  For those reasons, I'm not sure 
I would have labeled HDFS-13732 incompatible.

The way to make the change without breaking compatibility in any way is to add 
another CLI option.  {{hdfs ec -defaultPolicy -path /EC}} for example, which 
would set the policy to the default and print it, or maybe a {{-default}} 
option for {{-setPolicy}}.

> ECAdmin NPE with -setPolicy -replicate
> --------------------------------------
>
>                 Key: HDFS-13998
>                 URL: https://issues.apache.org/jira/browse/HDFS-13998
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: erasure-coding
>    Affects Versions: 3.2.0, 3.1.2
>            Reporter: Xiao Chen
>            Assignee: Zsolt Venczel
>            Priority: Major
>         Attachments: HDFS-13998.01.patch, HDFS-13998.02.patch, 
> HDFS-13998.03.patch
>
>
> HDFS-13732 tried to improve the output of the console tool. But we missed the 
> fact that for replication, {{getErasureCodingPolicy}} would return null.
> This jira is to fix it in ECAdmin, and add a unit test.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to