[ 
https://issues.apache.org/jira/browse/HDFS-14082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688988#comment-16688988
 ] 

Yiqun Lin commented on HDFS-14082:
----------------------------------

[~elgoiri], the setting name makes me confused. 
{{dfs.federation.router.client.require.response}} looks like it will makes 
sense to all rpc calls. We maybe need to documented related rpc calls that will 
be affected in hdfs-rbf-default.xml and comments. Or we can rename it to a 
readable setting name.

In order to keep compatible, the default value of the 
{{dfs.federation.router.client.require.response}} intends to be false.

Here I suppose we don't need to use a specific value to do the assertion. 
Defining a var {{requireSize}} and setting value firstly and then comparing the 
new value with initial value.
{code:java}
// Test the behavior when everything is fine
+    FileSystem fs = getRouterFileSystem();
+    FileStatus[] files = fs.listStatus(new Path("/"));
+    assertEquals(6, files.length);
...
assertTrue("We should have between 4 and 5 items: " + files.length,
+        files.length >= 4 && files.length < 6);
{code}

> RBF: Add option to fail operations when a subcluster is unavailable
> -------------------------------------------------------------------
>
>                 Key: HDFS-14082
>                 URL: https://issues.apache.org/jira/browse/HDFS-14082
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Íñigo Goiri
>            Assignee: Íñigo Goiri
>            Priority: Major
>         Attachments: HDFS-14082.000.patch, HDFS-14082.001.patch
>
>
> When a subcluster is unavailable, we succeed operations like 
> {{getListing()}}. We should add an option to fail the operation if one of the 
> subclusters is unavailable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to