[ 
https://issues.apache.org/jira/browse/HDFS-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uma Maheswara Rao G updated HDFS-2281:
--------------------------------------

    Status: Patch Available  (was: Open)

Hi Konstantin,

Thanks a lot for taking a look.

Actually this has been re-factored in trunk. So, as part of porting i included 
them. Actually we can make use of processIOError only.

So, Used processIOError for handling the failed storage directories.

Konstantin, can you take a look.

Test-patch results:

[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number 
of release audit warnings.
[exec]
[exec] +1 system test framework. The patch passed system test framework compile.

==============================
 Finished
==============================

Thanks
Uma

> NPE in checkpoint during processIOError()
> -----------------------------------------
>
>                 Key: HDFS-2281
>                 URL: https://issues.apache.org/jira/browse/HDFS-2281
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.22.0
>            Reporter: Konstantin Shvachko
>            Assignee: Uma Maheswara Rao G
>             Fix For: 0.22.0
>
>         Attachments: BN-bug-NPE.txt, HDFS-2281.1.patch, HDFS-2281.patch
>
>
> At the end of checkpoint BackupNode tries to convergeJournalSpool() and calls 
> revertFileStreams(). The latter closes each file stream, and tries to rename 
> the corresponding file to its permanent location current/edits. If for any 
> reason the rename fails processIOError() is called for failed streams. 
> processIOError() will try to close the stream again and will get NPE in 
> EditLogFileOutputStream.close() because bufCurrent was set to null by the 
> previous close.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to