[ 
https://issues.apache.org/jira/browse/HDDS-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693324#comment-16693324
 ] 

Mukul Kumar Singh commented on HDDS-835:
----------------------------------------

Thanks for updating the patch [~shashikant]. The update patch looks really good 
to me.
+1, the v1 patch looks good to me. There are some checkstyle issues in the 
latest patch which can be fixed while committing.

> Use storageSize instead of Long for buffer size configs in Ozone Client
> -----------------------------------------------------------------------
>
>                 Key: HDDS-835
>                 URL: https://issues.apache.org/jira/browse/HDDS-835
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>    Affects Versions: 0.4.0
>            Reporter: Shashikant Banerjee
>            Assignee: Shashikant Banerjee
>            Priority: Major
>             Fix For: 0.4.0
>
>         Attachments: HDDS-835.000.patch, HDDS-835.001.patch
>
>
> As per [~msingh] review comments in HDDS-675 , for streamBufferFlushSize, 
> streamBufferMaxSize, blockSize configs, we should use getStorageSize instead 
> of a long value, This Jira aims to address this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to