[
https://issues.apache.org/jira/browse/HDDS-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694379#comment-16694379
]
Mukul Kumar Singh commented on HDDS-814:
----------------------------------------
Thanks for updating the patch [~candychencan].
+1, v4 patch looks good to me. I will commit this shortly.
> dfs.ratis.leader.election.minimum.timeout.duration should not be read by
> client
> -------------------------------------------------------------------------------
>
> Key: HDDS-814
> URL: https://issues.apache.org/jira/browse/HDDS-814
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Arpit Agarwal
> Assignee: chencan
> Priority: Major
> Labels: newbie
> Attachments: HDDS-814.001.patch, HDDS-814.002.patch,
> HDDS-814.003.patch, HDDS-814.004.patch
>
>
> dfs.ratis.leader.election.minimum.timeout.duration is read by client for the
> following assertion.
> {code}
> Preconditions
> .assertTrue(maxRetryCount * retryInterval > 5 * leaderElectionTimeout,
> "Please make sure dfs.ratis.client.request.max.retries * "
> + "dfs.ratis.client.request.retry.interval > "
> + "5 * dfs.ratis.leader.election.minimum.timeout.duration");
> {code}
> This does not guarantee that the leader is using the same value as the
> client. We should probably just ensure that the defaults are sane and remove
> this assert.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
